Skip to content

ants: don't overwrite PATH in wrapper#391624

Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom
bcdarwin:fix-ants
Apr 10, 2025
Merged

ants: don't overwrite PATH in wrapper#391624
FliegendeWurst merged 1 commit intoNixOS:masterfrom
bcdarwin:fix-ants

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2025

Fixes #391554.

Possibly a bit overkill to add coreutils to every executable's path, but certainly the simplest approach.

@sceptri

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 20, 2025
@bcdarwin bcdarwin requested a review from isabelroses March 20, 2025 19:21
In this way coreutils is not removed from PATH.

Fixes NixOS#391554
@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 21, 2025
@bcdarwin bcdarwin mentioned this pull request Apr 8, 2025
@FliegendeWurst FliegendeWurst changed the title ants: add coreutils to PATH ants: don't overwrite PATH in wrapper Apr 10, 2025
@FliegendeWurst FliegendeWurst merged commit 3eff455 into NixOS:master Apr 10, 2025
36 checks passed
@bcdarwin bcdarwin deleted the fix-ants branch November 10, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANTs: .sh commands do not work

3 participants

Comments